Skip to content

Fix case sensitive check of filenames for symbols resolving. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Neloreck wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix case sensitive check of filenames for symbols resolving. #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion LuaDkmDebuggerComponent/LocalComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2609,8 +2609,12 @@ DkmResolvedDocument[] IDkmSymbolDocumentCollectionQuery.FindDocuments(DkmModule
}

var fileName = script.Value.resolvedFileName;
var sourceDocumentName = sourceFileId.DocumentName;

if (sourceFileId.DocumentName == fileName)
// Comparing file paths with ignoring case.
// OK for windows, but may be problematic with unix based operating systems.
// VS is not intended for usage with something else, so...
if (String.Equals(fileName, sourceDocumentName, StringComparison.OrdinalIgnoreCase))
{
var dataItem = new LuaResolvedDocumentItem
{
Expand Down