Make extra arguments customizable#138
Merged
Merged
Conversation
Owner
|
Most of these arguments are important for how deadgrep parses the output from rg. How about defining a customisable |
Many are required for deadgrep to be able to parse output, but others can be customized.
gvol
force-pushed
the
customizable-arguments
branch
from
89e1fe9 to
9757533
Compare
Author
|
Yeah, that's a better idea. :) |
Author
|
BTW, this has an ordering dependency with #93 (which I would love to get merged as well). Let me know which of them you would like to merge first and I can update the other with the appropriate changes (to tests). |
gvol
changed the title
Author
Owner
|
This looks good, merging :) |
Author
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to (easily) solve many of their own problems. For example, I have lots of types in my
~/.ripgreprcthat I don't want to repeat in Emacs, so--no-configis very bad for me. This should also solve #24, #110, and probably others that I have missed.