Add Playground PR preview workflows#911
Draft
fellyph wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run buildprocess, packagedist/as a slug-shapedtwo-factor.zip, and publish a Playground preview button after the read-only build workflow succeeds.Why
Two Factor needs generated preview files because the release build copies the QR code dependency from
node_modulesintodist/. The two-workflow setup keeps pull request code in a read-only build workflow, then lets the trustedworkflow_runpublish workflow expose the ZIP and update the PR description.Testing
npm ci.build/two-factor.zipextracts to a singletwo-factor/directory.npm run lint:js.npm run lint:css.composer validate --strict.composer lint-compat.composer lint-phpstan.PHPUnit was not run locally because
wp-envcould not connect to Docker in this environment.