fix(cicd): exec start script from entrypoint#2273
fix(cicd): exec start script from entrypoint#2273gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
Replace the final start.sh invocation with exec in the container entrypoint. This removes one extra shell layer so the start script inherits the entrypoint process directly.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the container entrypoint to exec the selected network start.sh script so it becomes the container’s primary process (PID 1), improving signal handling and avoiding an extra shell layer.
Changes:
- Replace the final
/work/start.shinvocation incicd/entry.shwithexec /work/start.sh.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Proposed changes
Replace the final start.sh invocation with exec in the container entrypoint. This removes one extra shell layer so the start script inherits the entrypoint process directly.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that