fix(consensus): fix error invalid merkle root on pre-tip-signing replay

[gzliudan]

Proposed changes

Symptom: nodes that resumed syncing from local state could fail checkpoint validation with an invalid merkle root while replaying pre-TIPSigning blocks after restart.

Cause: the non-TIP signing transaction replay path rebuilt signer data from raw receipts, but raw receipts may not carry TxHash metadata. As a result, signing transactions could be dropped and checkpoint rewards recalculated with totalSigner=0.

Fix: match non-TIP signing transactions to receipts by transaction index when receipt metadata is unavailable, keep the failed-receipt filter intact, and add regression tests covering both raw-receipt matching and end-to-end checkpoint reward replay through GetRewardForCheckpoint.

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 457fa752-ff0c-4717-b6c3-08c92eb1400d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes a consensus checkpoint validation failure (“invalid merkle root”) that could occur after a node restart when replaying pre-TIPSigning blocks, by ensuring signing transactions can be reconstructed from raw receipts even when receipt TxHash metadata is missing.

Changes:

• Updated pre-TIP signing-tx caching to locate the corresponding receipt by transaction index when TxHash metadata is unavailable, while preserving the “skip failed receipt” behavior.
• Added unit tests in the XDPoS engine to cover raw-receipt scenarios (no TxHash) and failed-receipt filtering.
• Added a higher-level regression test ensuring checkpoint reward replay correctly reconstructs signers after “restart-like” conditions (empty cache + raw receipts).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
consensus/XDPoS/XDPoS.go	Adds receipt lookup fallback by tx index to correctly cache pre-TIP signing txs from raw receipts without TxHash.
consensus/XDPoS/XDPoS_test.go	Adds focused unit tests covering raw receipts without TxHash, failed receipts by index, and rawdb round-trip behavior.
contracts/utils_test.go	Adds regression test verifying checkpoint reward replay reconstructs signing txs/signers from raw receipts after cache reset.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.