Skip to content

refactor(core): extract historical balance bypass rules#2283

Open
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:refactor-ApplyTransactionWithEVM
Open

refactor(core): extract historical balance bypass rules#2283
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:refactor-ApplyTransactionWithEVM

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan commented Apr 7, 2026

Proposed changes

Move the historical balance bypass table and application logic out of state_processor.go into a dedicated file.

Keep the state processing flow focused without changing the bypass behavior, and add focused tests for matching and non-matching historical rules.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 614d3a5a-10bf-4529-b765-13e71a9ed7fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the “historical balance bypass” logic out of core/state_processor.go into a dedicated module, keeping the transaction application flow cleaner while preserving the bypass behavior, and adds targeted unit tests around bypass matching vs skipping.

Changes:

  • Replace the inline historical-bypass table/logic in ApplyTransactionWithEVM with a call to applyHistoricalBalanceBypass.
  • Introduce core/state_processor_historical_bypass.go containing the bypass rules and application helper.
  • Add unit tests covering apply/skip scenarios for the historical bypass.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
core/state_processor.go Removes the large inline bypass block and calls the extracted helper during tx application.
core/state_processor_historical_bypass.go New dedicated bypass rules table and applyHistoricalBalanceBypass implementation.
core/state_processor_historical_bypass_test.go New tests validating bypass application and expected skip behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gzliudan gzliudan changed the title Refactor apply transaction with evm refactor(core): extract historical balance bypass rules Apr 7, 2026
Move the historical balance bypass table and application logic out of state_processor.go into a dedicated file.

Keep the state processing flow focused without changing the bypass behavior, and add focused tests for matching and non-matching historical rules.
@gzliudan gzliudan force-pushed the refactor-ApplyTransactionWithEVM branch from e97da95 to d6a38ad Compare April 7, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants