fix(core): refresh coinbase owner per transaction

[gzliudan]

Proposed changes

Problem: block processing reused a coinbase owner value captured before the transaction loop, so fee credits could go to a stale owner when the owner mapping changed during execution.

Cause: Process and ProcessBlockNoValidator computed coinbaseOwner once and passed it through ApplyTransactionWithEVM for every transaction in the block.

Solution: move the owner lookup into ApplyTransactionWithEVM so each transaction reads the current owner from state, remove the unused helper, and update tests to the new function signature.

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 21fe93ff-66fa-4e92-b30c-5150fe9dd5cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes incorrect fee recipient behavior during block processing by ensuring the coinbase “owner” is resolved from state for each transaction (instead of being computed once before iterating the block’s transactions). This prevents fee credits from going to a stale owner if the owner mapping changes mid-block.

Changes:

• Move coinbase owner lookup into ApplyTransactionWithEVM so it is refreshed per transaction.
• Remove the now-unneeded getCoinbaseOwner helper and adjust internal call sites accordingly.
• Update unit tests to match the new ApplyTransactionWithEVM function signature.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
core/state_processor.go	Computes coinbase owner inside ApplyTransactionWithEVM per-tx; removes helper; updates callers.
core/state_processor_test.go	Updates tests to call ApplyTransactionWithEVM with the new signature.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.