Skip to content

Validate repo_info before accessing version #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apermo wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Validate repo_info before accessing version #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fb083d
fix: validate repo_info before accessing version
apermo Apr 13, 2026
f5de638
fix(phpstan): separate version check from error branch
apermo Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions rt-plugin-report.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,9 +352,11 @@ private function assemble_plugin_report( $slug ) {
// Add the repo info to the report.
if ( isset( $returned_object ) ) {
if ( ! is_wp_error( $returned_object ) ) {
$report['repo_info'] = $returned_object;
// Cache the report.
set_site_transient( $cache_key, $report, self::CACHE_LIFETIME );
if ( isset( $returned_object->version ) ) {
$report['repo_info'] = $returned_object;
// Cache the report.
set_site_transient( $cache_key, $report, self::CACHE_LIFETIME );
}
Copy link
Copy Markdown
Contributor Author

@apermo apermo Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zodiac1978 Maybe we could add an else branch here to log the error? Your thoughts?

} else {
// Store the error code and message in the report.
$report['repo_error_code'] = $returned_object->get_error_code();
Expand Down Expand Up @@ -493,7 +495,7 @@ private function render_table_row( $report ) {
}

// Installed / available version.
if ( isset( $report['repo_info'] ) ) {
if ( isset( $report['repo_info'] ) && isset( $report['repo_info']->version ) ) {
$css_class = $this->get_version_risk_classname( $report['local_info']['Version'], $report['repo_info']->version );
$html .= '<td class="' . $css_class . '">';
$html .= esc_html( $report['local_info']['Version'] );
Expand Down
Loading