Update to skyspark class to work with both old GET and new POST methods#1
Open
shawk08033 wants to merge 1 commit intoaabdelfa:masterfrom
Open
Update to skyspark class to work with both old GET and new POST methods#1shawk08033 wants to merge 1 commit intoaabdelfa:masterfrom
shawk08033 wants to merge 1 commit intoaabdelfa:masterfrom
Conversation
Owner
|
Hey Shaun, hope all is well with you. You have to switch the post and Get settings to work with http instead of https. Can’t remember exactly from where as I haven’t done SkySpark in a couple of years now. Thanks,AlOn Jul 23, 2025, at 12:12 AM, Shaun Hawk ***@***.***> wrote:Al, hope you are doing well.
Adam from Ziva Tech pointed out you made this open source. I recently upgraded a server to a new Skyspark version and came across some issues with Skyspark using POST methods now.
Here's the updates to work with both POST and GET, feel free to merge if you still want to maintain this.
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
8b885dc Update to skyspark class to work with both old GET and new POST methods
File Changes (1 file)
M
skysparkClass.php
(355)
Patch Links:
https://github.com/aabdelfa/skyAuth-php/pull/1.patch
https://github.com/aabdelfa/skyAuth-php/pull/1.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Al, hope you are doing well.
Adam from Ziva Tech pointed out you made this open source. I recently upgraded a server to a new Skyspark version and came across some issues with Skyspark using POST methods now.
Here's the updates to work with both POST and GET, feel free to merge if you still want to maintain this.