Skip to content

fix: use valid sender fields in transaction examples #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Genmin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use valid sender fields in transaction examples #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
495da36
Fix transaction example sender fields
Genmin Apr 28, 2026
11f75df
Merge remote-tracking branch 'origin/main' into codex/fix-jsdoc-sende…
Genmin May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const result = await supply(client, {
value: '1000'
}
},
supplier: evmAddress('0x742d35cc6e5c4ce3b69a2a8c7c8e5f7e9a0b1234'),
sender: evmAddress('0x742d35cc6e5c4ce3b69a2a8c7c8e5f7e9a0b1234'),
chainId: chainId(1),
})
.andThen(sendWith(wallet))
Expand Down
2 changes: 1 addition & 1 deletion packages/client/src/actions/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export function hasProcessedKnownTransaction(
* value: '1000',
* },
* },
* borrower: evmAddress('0x9abc…'),
* sender: evmAddress('0x9abc…'),
* chainId: market.chain.chainId,
* },
* },
Expand Down
8 changes: 4 additions & 4 deletions packages/client/src/actions/transactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import type { AaveClient } from '../AaveClient';
* value: '1000',
* },
* },
* borrower: evmAddress('0x9abc…'),
* sender: evmAddress('0x9abc…'),
* chainId: market.chain.chainId,
* }).andThen(sendWith(wallet)).andThen(client.waitForTransaction);
*
Expand Down Expand Up @@ -86,7 +86,7 @@ export function borrow(
* value: '1000',
* },
* },
* supplier: evmAddress('0x9abc…'),
* sender: evmAddress('0x9abc…'),
* chainId: market.chain.chainId,
* }).andThen(sendWith(wallet)).andThen(client.waitForTransaction);
*
Expand Down Expand Up @@ -123,7 +123,7 @@ export function supply(
* },
* },
* },
* borrower: evmAddress('0x9abc…'),
* sender: evmAddress('0x9abc…'),
* chainId: market.chain.chainId,
* }).andThen(sendWith(wallet)).andThen(client.waitForTransaction);
*
Expand Down Expand Up @@ -158,7 +158,7 @@ export function repay(
* value: { exact: '750' },
* },
* },
* supplier: evmAddress('0x9abc…'),
* sender: evmAddress('0x9abc…'),
* chainId: market.chain.chainId,
* }).andThen(sendWith(wallet)).andThen(client.waitForTransaction);
*
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/ethers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export type SendTransactionError =
* value: '42.42',
* }
* },
* supplier: evmAddress(await signer.getAddress()),
* sender: evmAddress(await signer.getAddress()),
* })
* .andThen((plan) => {
* switch (plan.__typename) {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export function useUsdExchangeRates({
* value: '1000',
* },
* },
* borrower: evmAddress('0x9abc…'),
* sender: evmAddress('0x9abc…'),
* chainId: market.chain.chainId,
* },
* },
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/privy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export type SendTransactionError =
* value: '42.42',
* }
* },
* supplier: evmAddress(account.address!),
* sender: evmAddress(account.address!),
* })
* .andThen((plan) => {
* switch (plan.__typename) {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/thirdweb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export type SendTransactionError =
* value: '42.42',
* }
* },
* supplier: evmAddress(account!.address),
* sender: evmAddress(account!.address),
* })
* .andThen((plan) => {
* switch (plan.__typename) {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/viem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export type SendTransactionError =
* value: '42.42',
* }
* },
* supplier: evmAddress(account.address!),
* sender: evmAddress(account.address!),
* })
* .andThen((plan) => {
* switch (plan.__typename) {
Expand Down