forge: Add ChecksByChange and ChecksNone for per-change checks output#1263
Open
ed-irl wants to merge 1 commit into
Open
forge: Add ChecksByChange and ChecksNone for per-change checks output#1263ed-irl wants to merge 1 commit into
ed-irl wants to merge 1 commit into
Conversation
Collaborator
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Jun 13, 2026
e05989b to
cb608dc
Compare
Adds a display-oriented checks layer on top of upstream's per-check
ChangeChecks/ChangeCheckState API:
- forge.ChecksReport{Rollup, Runs, URL}: a per-change rollup plus
per-run detail and a checks summary URL.
- forge.ChecksRollupState (pending/passed/failed/none), with a
distinct 'none' for no checks configured/reported, and
TextMarshaler/Unmarshaler so it serializes as a string.
- forge.CheckRun{Name, State, URL}: per-run detail whose State
stays a forge-native string so the API need not enumerate every
forge's vocabulary.
- Repository.ChecksByChange(ids), a batch method mirroring
CommentCountsByChange.
Each forge stubs ChecksByChange (one nil per id) so the schema lands
standalone; real implementations follow per-forge.
cb608dc to
f473f97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lays the schema foundation for emitting per-change CI/build checks
in the gs ll JSON output. The actual rollup mappings + runs[] data
for each forge land in follow-up branches on this stack.
Adds:
configured/reported' (distinct from ChecksPassed). The card
indicator hides on none; pending/failed surface visually.
serializes as 'pending'|'passed'|'failed'|'none' in JSON.
Runs preserves forge-native state strings for fine-grained
surfaces (e.g. a future diff-view preamble), URL is the
forge's per-change checks page.
a string (forge-native vocabulary) so the upstream API doesn't
have to enumerate every forge's taxonomy.
CommentCountsByChange.
Each forge's ChecksByChange is stubbed to return a slice of nils
(equivalent to 'no data' under the contract) so the schema commit
builds standalone; real implementations land per-forge in the
follow-ups.