Conversation
Introduce the public type surface and package.json declarations for the
new per-side Pub/Sub packages, so the shape can be reviewed before any
implementation or build wiring lands:
- @ably/pubsub-common (internal, never published): self-contained copies
of the cross-side types, with client options decomposed into
CommonClientOptions/HttpOptions/RealtimeOptions and no value
declarations
- @ably/pubsub-device: createClient() returning a realtime client with
required clientId and device push (activate/deactivate), without push
admin or stats
- @ably/pubsub-server: createHttpClient() and createRealtimeClient(),
with push admin, stats and token revocation, without device push
- @ably/pubsub-react: the React hooks surface typed against DeviceClient
- @ably/pubsub-react-native: device client with app-supplied push
storage/token acquisition and push.updateToken(); no exports map so
older Metro resolvers can resolve it
Factories are declared against interfaces only ("doors, not rooms");
the deprecated v1 surface (callback overloads, device(),
environment/restHost/realtimeHost options) is dropped. The root
package.json gains npm workspaces and a check:packages script that
type-checks all five packages.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Introduce the public type surface and package.json declarations for the
new per-side Pub/Sub packages, so the shape can be reviewed before any
implementation or build wiring lands:
@ably/pubsub-common(internal, never published): self-contained copiesof the cross-side types, with client options decomposed into
CommonClientOptions/HttpOptions/RealtimeOptions and no value
declarations
@ably/pubsub-device:createClient()returning a realtime client withrequired clientId and device push (activate/deactivate), without push
admin or stats
@ably/pubsub-server:createHttpClient()andcreateRealtimeClient(),with push admin, stats and token revocation, without device push
@ably/pubsub-react: the React hooks surface typed againstDeviceClient@ably/pubsub-react-native: device client with app-supplied pushstorage/token acquisition; no exports map so
older Metro resolvers can resolve it