Open
Conversation
Also commented out code related to donors section in Core component
Primary changes: Gilroy as the primary font, color adjustments, created styled components for visual consistency.
Key changes: Created variable style properties for light and dark mode (updated styles.css), updated all component files to use these variables for consistent theming. NOTE: These changes were made before Vivi's commit so some of her changes may not be reflected in this commit. If there's a merge conflict, I'll handle it.
Solved merge conflicts in several files.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Although we change the font I would like the colors for all the text to remain the same how it was originally for example, the text for by ACM DEV is lighter in the original, and the search bar is not filled in. Other than that the dark mode colors are nice, just make sure to update the toggle transition so it's smoother, and remove the text "light" and "dark" |
Dark mode is now more reflective of the old color scheme and light mode is pretty much replicated from prod.
Everything should be good now 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend update complete!!
Primary changes:
Dark / Light Mode Integration: Implemented toggle across all pages for users to switch as needed. In the codebase, this involved rewriting
styles.cssto use conditional variable style properties throughout the website for light and dark mode.Font Changes: UTDGrades now uses
Gilroyto match ACM's branding. That's pretty much it.Vivi's Changes: I added Vivi's changes into this pull request as well. Great work with the navigation, hotkeys, and overall quality of life improvements. 👏