Fix template injection in e2e-versions.yml (alert #123)#1119
Closed
brunoborges with Copilot wants to merge 3 commits into
Closed
Fix template injection in e2e-versions.yml (alert #123)#1119brunoborges with Copilot wants to merge 3 commits into
brunoborges with Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code scanning alert #123
Fix template injection in e2e-versions.yml (alert #123)
Jul 14, 2026
brunoborges
approved these changes
Jul 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mitigates a zizmor/template-injection code-scanning alert in the e2e-versions.yml workflow by preventing direct GitHub expression interpolation inside a bash run: script, instead passing step outputs via environment variables.
Changes:
- Moved
${{ steps.setup-java-21.outputs.path }}and${{ steps.setup-java-21.outputs.version }}into the step’senv:block. - Updated the bash script to reference
$JAVA21_PATHand$JAVA21_VERSION(quoted) rather than inline${{ ... }}expressions.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/e2e-versions.yml |
Moves Java 21 output references into env to avoid template expansion inside the shell script and reduce injection risk. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Resolves a
zizmor/template-injectioncode scanning alert in the "Verify Java 21 outputs are set" workflow step. Inline${{ steps.setup-java-21.outputs.* }}expressions inside arunshell script are evaluated before the shell sees the string, meaning a malicious output value could inject arbitrary shell commands.Fix: Move template expressions to the step's
envblock and reference them as plain shell variables:Both
outputs.pathandoutputs.versionare moved toenv, eliminating direct template expansion inside the shell script.Related issue:
Code scanning alert #123
Check list:
npm run checklocally (format, lint, build, test) and all checks pass.