Open
Conversation
before this, if a tour was encountered where tourMayStart was false, then subsequent tours were not attempted now, all incomplete tours are looped through until the first runable one is run for...in is used because it is the most compatible
Author
|
@canderson180 @aashishpsaini wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this, if a tour was encountered where tourMayStart
was false, then subsequent tours were not attempted
now, all incomplete tours are looped through until the first
runable one is run
for...in is used because it is the most compatible
example tour that this fix accommodates: