Skip to content

chore(schema): sync registry.yaml and registry types - #2431

Merged
bokelley merged 2 commits into
mainfrom
chore/sync-registry-codegen
Jul 31, 2026
Merged

chore(schema): sync registry.yaml and registry types#2431
bokelley merged 2 commits into
mainfrom
chore/sync-registry-codegen

Conversation

@bokelley

@bokelley bokelley commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Fixes #2430.

The "Validate generated files are in sync" step of Generated, Docs & Formatting has been red on main itself — run 30587961761 at f8f24fb5. Every PR opened against main inherits the failure, so the check carries no signal and each reviewer re-diagnoses it. It also fails the Test & Build rollup, which needs: generated-checks.

Confirmed fixed: that step passes on this branch.

Output of the three commands the CI step runs:

npm run sync-schemas:all
npm run generate-types
npm run generate-registry-types -- --sync

Only schemas/registry/registry.yaml and src/lib/registry/types.generated.ts drift. npm run generate-types alone produces none, and ci:docs-check, ci:codegen-strict, ci:doc-links, lint:workflows, and format:check are all clean — so this is specifically the registry pair falling behind an upstream registry that has grown.

No hand edits. Purely the generator's output, so review it by re-running the commands rather than by reading the diff.

Kept standalone on purpose: folding 1,100+ lines of generated churn into a feature branch makes the real diff unreviewable, and CLAUDE.md tells reviewers not to read generated files, so it would land unexamined either way.

Changeset included as patch — the registry types are published, so this is an additive type-surface change rather than a pure no-op. (An earlier revision of this description claimed no changeset was needed; the Check for changeset gate correctly disagreed, since src/lib/registry/types.generated.ts ships.)

Worth a follow-up: schema-sync.yml is the daily job meant to open exactly this PR automatically. Since it didn't, it's probably failing or drifted and should be checked.

🤖 Generated with Claude Code

The "Validate generated files are in sync" CI step has been red on main
(run 30587961761 at f8f24fb): the upstream registry has grown and the
committed copies are stale, so every PR opened against main inherits a
failing check that has nothing to do with it.

Output of:

  npm run sync-schemas:all
  npm run generate-types
  npm run generate-registry-types -- --sync

Only registry.yaml and registry/types.generated.ts drift — generate-types
alone produces none, and ci:docs-check, ci:codegen-strict, ci:doc-links,
lint:workflows, and format:check are all clean.

Kept standalone deliberately. Folding 1100+ lines of generated churn into
a feature branch would make the real diff unreviewable, and CLAUDE.md
tells reviewers not to read generated files, so it would land unexamined.

Refs #2430

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean generated-artifact sync.

This PR regenerates schemas/registry/registry.yaml from upstream and src/lib/registry/types.generated.ts from it, adding the community-mirror proposal workflow (list/get/approve/reject paths + proposal schemas). The two files are internally consistent (required/optional fields match). The apparent rename of CommunityMirror{List,Summary,Get} is a re-add, not a removal, so the published type surface is additive. No changeset is required (generated-file carve-out; schemas/ not in package.json files; CI changeset check green).

No blocking findings.

Decision-table walk:

  • Row 1: no critical/high findings — skip.
  • Row 2: gated_paths is false — skip.
  • Row 3: high_risk true but reason is (modified), no (deleted) — skip.
  • Row 4/5: no medium findings — skip.
  • Row 6: no prior decision — skip.
  • Row 7: no no-auto-approve team match — skip.
  • Row 8: fewer than three medium findings — skip.
  • Row 9: approve.

Note: high_risk is true because schemas/registry/registry.yaml matches schemas/registry/**, but it is a (modified) change with no medium-or-higher findings, so per the heuristic-flag guidance this is presumed safe and does not escalate.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approval: no reviewable delta since the prior approval; re-submitting after stale-review dismissal.

@bokelley
bokelley merged commit 0852df0 into main Jul 31, 2026
33 checks passed
@bokelley
bokelley deleted the chore/sync-registry-codegen branch July 31, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: 'Validate generated files are in sync' is red on main — registry.yaml and registry types are stale

1 participant