chore(schema): sync registry.yaml and registry types - #2431
Conversation
The "Validate generated files are in sync" CI step has been red on main (run 30587961761 at f8f24fb): the upstream registry has grown and the committed copies are stale, so every PR opened against main inherits a failing check that has nothing to do with it. Output of: npm run sync-schemas:all npm run generate-types npm run generate-registry-types -- --sync Only registry.yaml and registry/types.generated.ts drift — generate-types alone produces none, and ci:docs-check, ci:codegen-strict, ci:doc-links, lint:workflows, and format:check are all clean. Kept standalone deliberately. Folding 1100+ lines of generated churn into a feature branch would make the real diff unreviewable, and CLAUDE.md tells reviewers not to read generated files, so it would land unexamined. Refs #2430 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean generated-artifact sync.
This PR regenerates schemas/registry/registry.yaml from upstream and src/lib/registry/types.generated.ts from it, adding the community-mirror proposal workflow (list/get/approve/reject paths + proposal schemas). The two files are internally consistent (required/optional fields match). The apparent rename of CommunityMirror{List,Summary,Get} is a re-add, not a removal, so the published type surface is additive. No changeset is required (generated-file carve-out; schemas/ not in package.json files; CI changeset check green).
No blocking findings.
Decision-table walk:
- Row 1: no critical/high findings — skip.
- Row 2:
gated_pathsis false — skip. - Row 3:
high_risktrue but reason is(modified), no(deleted)— skip. - Row 4/5: no medium findings — skip.
- Row 6: no prior decision — skip.
- Row 7: no no-auto-approve team match — skip.
- Row 8: fewer than three medium findings — skip.
- Row 9: approve.
Note: high_risk is true because schemas/registry/registry.yaml matches schemas/registry/**, but it is a (modified) change with no medium-or-higher findings, so per the heuristic-flag guidance this is presumed safe and does not escalate.
Fixes #2430.
The "Validate generated files are in sync" step of
Generated, Docs & Formattinghas been red onmainitself — run 30587961761 atf8f24fb5. Every PR opened againstmaininherits the failure, so the check carries no signal and each reviewer re-diagnoses it. It also fails theTest & Buildrollup, whichneeds: generated-checks.Confirmed fixed: that step passes on this branch.
Output of the three commands the CI step runs:
Only
schemas/registry/registry.yamlandsrc/lib/registry/types.generated.tsdrift.npm run generate-typesalone produces none, andci:docs-check,ci:codegen-strict,ci:doc-links,lint:workflows, andformat:checkare all clean — so this is specifically the registry pair falling behind an upstream registry that has grown.No hand edits. Purely the generator's output, so review it by re-running the commands rather than by reading the diff.
Kept standalone on purpose: folding 1,100+ lines of generated churn into a feature branch makes the real diff unreviewable, and
CLAUDE.mdtells reviewers not to read generated files, so it would land unexamined either way.Changeset included as
patch— the registry types are published, so this is an additive type-surface change rather than a pure no-op. (An earlier revision of this description claimed no changeset was needed; theCheck for changesetgate correctly disagreed, sincesrc/lib/registry/types.generated.tsships.)Worth a follow-up:
schema-sync.ymlis the daily job meant to open exactly this PR automatically. Since it didn't, it's probably failing or drifted and should be checked.🤖 Generated with Claude Code