chore: release package (rc) - #2437
Conversation
bokelley
left a comment
There was a problem hiding this comment.
Validated release metadata for @adcp/sdk 13.0.0-rc.6; patch note and generated version files match the merged changeset.
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — automated Changesets release PR (chore: release package (rc)), no findings.
Checked:
- Version bump @adcp/sdk 13.0.0-rc.5 → 13.0.0-rc.6 is consistent across package.json, package-lock.json, client-shim dependency pin, and src/lib/version.ts (both LIBRARY_VERSION and VERSION_INFO.library).
- CHANGELOG entry matches the consumed patch changeset (f01ac27).
- .changeset/pre.json correctly records the changeset in pre mode.
- No src/lib behavioral code changed; version.ts is a mechanical version string update.
No critical/high/medium findings. gated_paths is false, review_decision is APPROVED, high_risk is false, no no-auto-approve team match. Falls through to row 9.
59c292f
There was a problem hiding this comment.
Ladon verdict: Approve
Approve.
This PR is a generated registry sync. The delta since the prior approved review adds three additive rejection-code enum values (array_too_many, array_too_few, aggregate_too_long) and widens resource from string to string|string[] (RFC 8707 multi-resource, 1–8 items).
Checks:
- Schema (
schemas/registry/registry.yaml) and generated types (src/lib/registry/types.generated.ts) are consistent. - New enum codes are additive with no runtime consumer to break.
resourcewidening is caller-additive on a request param with no internal reader.- The sync-registry-codegen changeset (
patch) covers the wire impact correctly.
Gate checks: no no-auto-approve team match; gated_paths is false; high_risk is true only for a (modified) schema file, but the reviewer found no medium-or-higher concerns, so the modification is presumed safe (not an escalation trigger). No blocking findings.
Decision table: rows 1–8 do not fire (no critical/high/medium findings, no gated-paths block, no deletion, no team gate) → row 9 approve.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
mainis currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, runchangeset pre exitonmain.Releases
@adcp/sdk@13.0.0-rc.6
Patch Changes
primary_channelsandprimary_countriesfrom spec-compliant sales agents.