Added recent changes and moved byIdAndDate to new profile

[alexgordtop]

No description provided.

[BirgitBoss]

only GetAssetAdministrationShellVersionByIdAndDate? Probably Get AAS Version by ID or AssetId or Date

[sebbader-sap]

GetAllAssetAdministrationShellsByAssetId and GetAllAssetAdministrationShells look also wrong to me... Maybe a copy-paste issue?

[alexgordtop]

Should have been:

  x-semanticIds:
    - https://admin-shell.io/aas/API/GetAssetAdministrationShellRecentChanges/3/2

[BirgitBoss]

Suggested change

	e|id |Globally unique identification of the Asset Administration Shell |link:https://industrialdigitaltwin.io/aas-specifications/IDTA-01001/v3.1/spec-metamodel/datatypes.html#Identifier[Identifier] |1
	e|id a|Globally unique identification of the Asset Administration Shell |link:https://industrialdigitaltwin.io/aas-specifications/IDTA-01001/v3.2/spec-metamodel/datatypes.html#Identifier[Identifier] |1

[BirgitBoss]

Are you assuming the updatedAt information or version information is somehow part of the AAS ID?

[sebbader-sap]

I wouldn't enforce that. Versioned IDs have turned out to be a pretty bad idea, they make it hard to find the same object over time.

[BirgitBoss]

In https://industrialdigitaltwin.io/aas-specifications/IDTA-01001/v3.1.2/spec-metamodel/common.html#administrative-information-attributes we write:

Note 1: typically, some of the administrative information like the version number might be part of the identification (Submodel/id). This is similar to the handling of identifiers for concept descriptions using IRDIs. In ECLASS, the IRDI 0173-1#02-AO677#002 contains the version information 002.

[BirgitBoss]

I think I mixed recentChanges and dateAndTime

[BirgitBoss]

I wouldn't enforce that. Versioned IDs have turned out to be a pretty bad idea, they make it hard to find the same

I agree

But this means that the AAS and Submodel repository do not contain archived versions (with same ID), this is an additional component with different APIs.

[BirgitBoss]

Suggested change

	|createdAt |The point in time at which the Identifiable object was created |link:https://industrialdigitaltwin.io/aas-specifications/IDTA-01001/v3.2/spec-metamodel/datatypes.html#DateTimeUtc[DateTimeUtc] | 1
	|createdAt a|The point in time at which the Identifiable object was created |link:https://industrialdigitaltwin.io/aas-specifications/IDTA-01001/v3.2/spec-metamodel/datatypes.html#DateTimeUtc[DateTimeUtc] | 1

[BirgitBoss]

Suggested change

	|updatedAt |The point in time at which the Identifiable object was recently updated |link:https://industrialdigitaltwin.io/aas-specifications/IDTA-01001/v3.2/spec-metamodel/datatypes.html#DateTimeUtc[DateTimeUtc] | 1
	|updatedAt a|The point in time at which the Identifiable object was recently updated |link:https://industrialdigitaltwin.io/aas-specifications/IDTA-01001/v3.2/spec-metamodel/datatypes.html#DateTimeUtc[DateTimeUtc] | 1

[BirgitBoss]

Only one Submodel? So no result for AAS only or for a single AAS only or for an AAS together with all its Submodels?

Probabably both optional?

You cannot have twice the same attribute "id". Do you mean it depends on context which ID is returned? ==> remove both IDs here, they are added later

[sebbader-sap]

But same for the AAS.id in the row above, or? AssetAdministrationShellRecentChange and SubmodelRecentChange include them.

[BirgitBoss]

why add "earliest"? We need "create before or at exactly at this date" Earliest means the opposite: created after or at exactly this date?

[BirgitBoss]

if there is a cursor there shall also be a limi: pagination should be identical in all cases it is used

However, in other API operation cursor and limit are input parameters and not part of the payload class: this seems inconsistent to the rest?

[BirgitBoss]

we could also add version and revision (both optional) to this class, otherwise we would need another one for these attributes

[sebbader-sap]

Sorry for the chaos in my comments, took me some time to get the idea...