Surface copyright header rule in skills and clarify format#2985
Merged
Surface copyright header rule in skills and clarify format#2985
Conversation
Copilot
AI
changed the title
[WIP] Add linting skill and refactor existing skills and documentation
Add lint skill and wire it into the agent skill workflow
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated lint skill for the S3Mock agent skill workflow, consolidating scattered references to make format and providing comprehensive guidance on both ktlint and Checkstyle linting tools.
Changes:
- Added new
.claude/skills/lint/SKILL.mddocumenting ktlint (auto-fix) and Checkstyle (manual fix) workflows - Integrated lint skill as step 3 in the implement skill workflow (between coding and testing)
- Updated implement, refactor, test, and review skills to reference the lint skill instead of bare
make formatcommands - Enhanced AGENTS.md to clarify that
make formatis ktlint-specific and point to the lint skill
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.claude/skills/lint/SKILL.md |
New skill documenting ktlint and Checkstyle linting tools, workflow, and common violations |
.claude/skills/implement/SKILL.md |
Added lint skill as step 3 in workflow; replaced make format references with lint skill invocations |
.claude/skills/refactor/SKILL.md |
Updated checklist to invoke lint skill instead of running make format |
.claude/skills/test/SKILL.md |
Updated checklist to invoke lint skill instead of running make format |
.claude/skills/review/SKILL.md |
Extended CI gates checklist to suggest lint skill when style violations found |
AGENTS.md |
Annotated make format as ktlint-specific; added pointer to lint skill for complete linting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot
AI
changed the title
Add lint skill and wire it into the agent skill workflow
Surface copyright header rule in skills and clarify format
Mar 17, 2026
Member
|
@copilot rebase against |
Contributor
Author
Rebased onto |
Co-authored-by: afranken <763000+afranken@users.noreply.github.com>
…TS.md Co-authored-by: afranken <763000+afranken@users.noreply.github.com>
afranken
force-pushed
the
copilot/add-linting-skill-and-refactor
branch
from
125a4c2 to
491abfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skills had no mention of the copyright header update requirement, so agents following skill workflows would silently skip it. The
AGENTS.mdrule also lacked the exact format, leaving the2017-start year implicit.Changes
AGENTS.md2017-<current year>(e.g.,2017-2026)implement,refactor,testskillsUpdate copyright year to \2017-` in the header of every file you modify`reviewskill✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.