fix: #6938 Prevent actionbar dropdown from sliding off at small widths - #10399
Open
jsmitrah wants to merge 2 commits into
Open
fix: #6938 Prevent actionbar dropdown from sliding off at small widths#10399jsmitrah wants to merge 2 commits into
jsmitrah wants to merge 2 commits into
Conversation
| align-items: center; | ||
| min-width: 0; | ||
| isolation: isolate; | ||
| justify-content: space-between; |
Member
There was a problem hiding this comment.
Please explain the changes, because I would not have expected this property to change
Author
There was a problem hiding this comment.
justify-content: space-between: I removed it because it wasn't doing anything.
In this grid, the third column is 1fr, which automatically takes up all the remaining space. Since there's no extra space left, justify-content: space-between has nothing to distribute. So removing it doesn't change the layout or behavior, it was simply unused code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6938
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: