Skip to content

fix: #6938 Prevent actionbar dropdown from sliding off at small widths - #10399

Open
jsmitrah wants to merge 2 commits into
adobe:mainfrom
jsmitrah:fix/6938/actionbar-menu-overflow
Open

fix: #6938 Prevent actionbar dropdown from sliding off at small widths#10399
jsmitrah wants to merge 2 commits into
adobe:mainfrom
jsmitrah:fix/6938/actionbar-menu-overflow

Conversation

@jsmitrah

Copy link
Copy Markdown

Closes #6938

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • Open the React Spectrum ActionBar component, shrink it to less than 192px, and verify the menu does not disappear.

🧢 Your Project:

align-items: center;
min-width: 0;
isolation: isolate;
justify-content: space-between;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain the changes, because I would not have expected this property to change

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

justify-content: space-between: I removed it because it wasn't doing anything.

In this grid, the third column is 1fr, which automatically takes up all the remaining space. Since there's no extra space left, justify-content: space-between has nothing to distribute. So removing it doesn't change the layout or behavior, it was simply unused code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action Bar's dropdown menu slides off when action bar is small

2 participants