Update on.{pull_request,push}.paths triggers for .github/workflows/build-*.yml#274
Merged
Merged
Conversation
Ensures that build-related workflows are run on push or pull_request changes to the repository's root-level package*.json files.
data-douser
added
dependencies
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflow paths filters so build workflows run when root-level npm dependency files change, ensuring CI catches dependency updates that affect server/client/extension builds in this monorepo.
Changes:
- Added root
package.jsonandpackage-lock.jsontobuild-server.ymlworkflow triggers. - Added root
package.jsonandpackage-lock.jsontobuild-and-test-extension.ymlworkflow triggers. - Added root
package.jsonandpackage-lock.jsontobuild-and-test-client.ymlworkflow triggers (and reordered the existing.codeql-versionentry within the paths list).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/build-server.yml | Triggers server build workflow on root dependency file changes. |
| .github/workflows/build-and-test-extension.yml | Triggers extension build/test workflow on root dependency file changes. |
| .github/workflows/build-and-test-client.yml | Triggers client build/test workflow on root dependency file changes. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that build-related workflows are run on push or pull_request changes to the repository's root-level package*.json files.
Outline of Changes
Workflow trigger improvements:
package.jsonandpackage-lock.jsonto the trigger paths for thebuild-and-test-client.ymlworkflow, so changes to these files will now trigger this workflow.package.jsonandpackage-lock.jsonto the trigger paths for thebuild-and-test-extension.ymlworkflow, ensuring it runs when dependencies are updated. [1] [2]package.jsonandpackage-lock.jsonto the trigger paths for thebuild-server.ymlworkflow, so server builds are triggered by dependency changes.