fix: correct negative edge extraction and directed rewiring in signed - #138
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
Fix 1: Introduced inline multiplication by s during strength and sorted-weight extraction (e.g., Si = np.sum(W * Acur * s) and Wv = np.sort(W[Acur] * s)) in both null_model_und_sign and null_model_dir_sign. This ensures the algorithm extracts positive magnitudes during the negative branch, restoring the original MATLAB logic (where -W.*An was used).
Fix 2: Changed the rewiring call inside null_model_dir_sign from randmio_und_signed to randmio_dir_signed to correctly preserve asymmetric directed topology and independent in/out degree distributions.
Tests: Added comprehensive regression tests in test_null_model_sign.py to verify that negative edges are preserved and that exact per-node positive and negative degree distributions are perfectly maintained.