feat(web): merge Auto-review into permission modes - #410
Conversation
There was a problem hiding this comment.
Clean, well-scoped refactor. Verified the preset composition logic:
permissionModePresetscorrectly injects theAutopill only when the runtime supports approvals-reviewer andagentis in the mode list.selectedPermissionPreset/permissionPresetSettingsround-trip correctly (agent+auto_review⇄agent:auto-review), and switching to any other preset resetsapprovalsReviewertouserper the PR description.agentPermissionDisplay's new optionalapprovalsReviewerparam correctly falls back to prior behavior when omitted (e.g.SessionDetailView.tsxcall site untouched).- Confirmed no leftover references to removed exports (
supportsApprovalsReviewer,approvalsReviewerOptions,approvalsReviewerLabel) outsidedata.ts. - Tests updated consistently with the new API shape.
No blocking issues found.
sent by review-bot-fast (Claude Agent · sonnet) · open in session
There was a problem hiding this comment.
Approved at exact head 681dd7d3e003174a25ba12d81069fefb31c32cec. The Agent create/edit controls correctly compose the UI-only Auto preset as permissionMode=agent plus approvalsReviewer=auto_review, while every other Codex preset restores the reviewer to user. Non-Codex runtime catalogs and the session composer retain their raw permission-mode behavior, Agent Detail resolves the combined preset, and the scrollable non-wrapping pill row preserves the four choices on narrow layouts.
Validation on this revision passed all 579 web tests, web typecheck, the web production build, changed-file ESLint/Prettier, and diff hygiene. The exact-head GitHub Build, Check, Unit, Skill sandbox, both Integration shards, Semantic PR, and companion review checks are also green.
Non-blocking active-development warning: a previously persisted or API-authored noncanonical pair such as permissionMode=agent-full-access with approvalsReviewer=auto_review is displayed as Full Access while retaining the hidden reviewer value until the operator actively selects a preset. That migration behavior is acceptable for this unreleased system.
sent by review-bot (Codex · gpt-5.6-sol) · open in session
Summary
Permission modeandApproval reviewercontrols with one four-preset permissions row:Read-only,Agent,Auto, andAgent (full access)Autopreset topermissionMode=agentplusapprovalsReviewer=auto_review; selecting another Codex preset restoresapprovalsReviewer=userWhy
Follow-up to #407. codex-acp correctly exposes permission mode and approval reviewer as independent session options, but users should choose the familiar combined Codex permissions preset rather than coordinate two protocol-level controls.
The raw permission-mode catalog and session composer remain unchanged because session controls currently stage only the runtime mode, not the Agent-level reviewer preference.
Validation
Created by Codex . GPT-5.6 Sol