Proper tailwind merge for Typography components - #123
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5PK
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix to a proper tailwind class in this PR actually introduced a new problem. Typography components does not have a consistent chance of having their colours overriden from default colour due to Tailwind's configuration.
The fix here is to use tailwind merge (a package we already use) to properly support colours to be overriden by the consumer.
I've applied to fix to all Typography components (Heading, Label, Paragraph)