[Bug][Docs] Fix UCX TCP connection issue and add setup guide#49
Conversation
Signed-off-by: bob-021206 <binyan_github@163.com>
Signed-off-by: bob-021206 <binyan_github@163.com>
Signed-off-by: bob-021206 <binyan_github@163.com>
… arity) Signed-off-by: bob-021206 <binyan_github@163.com>
|
Hi @Jeffwan @DwyaneShi, just wanted to kindly follow up on this PR when you have a chance. I’d appreciate any review or feedback. Thanks! |
|
@bob-021206 Thanks for the contribution. The PR looks good to me overall, and I left some minor comments. Thanks in advance for addressing the comments from the reviewers. |
|
@DwyaneShi Thanks for the review! We are also working on AIBrix and vLLM-Omni compatibility, which requires using the pypriskv Python package directly. Do you have any plan to publish pypriskv to PyPI in the future so it can be installed via pip install? |
| connfd = accept(listener->listenfd, (struct sockaddr *)&client_addr, &client_addr_len); | ||
| if (connfd < 0) { | ||
| if (errno == EAGAIN || errno == EWOULDBLOCK) { | ||
| // no connection available, return |
There was a problem hiding this comment.
let's keep these comments
|
@bob-021206 There are some building issues to be fixed. I'll publish pypriskv to PyPI after this PR getting merged. |
|
I'll merge this PR and the building issue will be fixed in a follow-up PR separately. |
3 participants
Pull Request Description
This PR fixes an issue with UCX TCP connections and adds a setup guide for using UCX over TCP.
Motivation
During development and testing, UCX TCP connections were found to be unstable under certain conditions, leading to connection failures or unexpected behavior. In addition, there was no clear documentation on how to properly configure UCX for TCP usage, which made debugging and setup more difficult.
Root Cause
The issue was related to improper handling and/or configuration of UCX TCP connections, which could lead to failures during initialization or data transfer.
Changes
SETUP_UCX_TCP.mdwith detailed instructions for configuring UCX TCPImpact
Related Issues
N/A
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to PrisKV! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to PrisKV's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.