Skip to content

Skip Next project during coverage runs#492

Merged
aidenybai merged 0 commit into
feat/e2e-coveragefrom
main
Jun 26, 2026
Merged

Skip Next project during coverage runs#492
aidenybai merged 0 commit into
feat/e2e-coveragefrom
main

Conversation

@aidenybai

@aidenybai aidenybai commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Treat COVERAGE runs as Vite-only in Playwright config
  • Skip the chromium-next project and Next dev server when coverage is enabled to avoid racing the shared react-grab dist build

Testing

  • pnpm build
  • COVERAGE=1 pnpm --filter react-grab exec playwright test --list (708 tests, no chromium-next entries)
  • pnpm --filter react-grab exec playwright test --list (713 tests, includes chromium-next)
  • pnpm lint
  • pnpm typecheck
  • pnpm format
  • pnpm test
Open in Web Open in Cursor 

Summary by cubic

Make coverage runs Vite-only by skipping the Next project, and simplify the discard-selection prompt so Enter confirms and arrows are ignored. This reduces flakiness and keeps key behavior consistent.

  • Bug Fixes
    • Playwright: when COVERAGE is set, skip the Next project and dev server to avoid racing the shared react-grab dist build (mirrors PERF_LABEL).
    • Keyboard navigation: pressing Enter confirms discard; arrow keys and bare shortcuts do not pass through while the prompt is visible. Updated e2e tests to match.

Written for commit 81d95cc. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-grab-storybook Ready Ready Preview, Comment Jun 26, 2026 10:47am
react-grab-website Ready Ready Preview, Comment Jun 26, 2026 10:47am

@pkg-pr-new

pkg-pr-new Bot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@react-grab/cli@492
npm i https://pkg.pr.new/grab@492
npm i https://pkg.pr.new/react-grab@492

commit: 81d95cc

@aidenybai aidenybai merged commit 81d95cc into feat/e2e-coverage Jun 26, 2026
16 checks passed
@aidenybai aidenybai force-pushed the feat/e2e-coverage branch from a72235b to dcd0fbb Compare June 26, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant