Skip Next project during coverage runs#492
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
a72235b to
dcd0fbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pnpm buildCOVERAGE=1 pnpm --filter react-grab exec playwright test --list(708 tests, nochromium-nextentries)pnpm --filter react-grab exec playwright test --list(713 tests, includeschromium-next)pnpm lintpnpm typecheckpnpm formatpnpm testSummary by cubic
Make coverage runs Vite-only by skipping the Next project, and simplify the discard-selection prompt so Enter confirms and arrows are ignored. This reduces flakiness and keeps key behavior consistent.
COVERAGEis set, skip the Next project and dev server to avoid racing the sharedreact-grabdist build (mirrorsPERF_LABEL).Written for commit 81d95cc. Summary will update on new commits.