Allow keyboard pass-through from selection prompt#493
Merged
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 142654b. Configure here.
Contributor
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
sand Enter pass through from that promptTests
pnpm --filter react-grab exec playwright test e2e/keyboard-navigation.spec.ts --reporter=listpnpm --filter react-grab run typecheckpnpm --filter react-grab run test:unitNotes
main, I reverted the prompt commits onmainwith a normal revert commit and reapplied them on thiscursor/branch.Summary by cubic
Allow keyboard pass-through from the discard-selection prompt in
react-grab. Arrow keys continue navigation and dismiss the prompt only after a successful move; bare shortcuts (e.g., s, Enter) run their actions, and Enter on Copy/Yes still works.tryHandleKeyboardSelectionPromptPassThrough; extractedgetBareKeyShortcutandisKeyboardSelectionPromptButtonEnter; addedallowPendingKeyboardSelectiontotryHandleArrowNavigationand only clear navigation/dismiss the prompt after a valid move.showKeyboardSelectionDiscardPrompt.Written for commit c486897. Summary will update on new commits.