Open
Conversation
added 4 commits
September 12, 2024 01:03
Tags should close themselves by default unless they are self-closing[1]. An unclosed script tag in particular, commonly used to include external javascript files, will eat the rest of the page. 1. List of self-closing tags here: https://developer.mozilla.org/en-US/docs/Glossary/Void_element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All empty HTML tags are currently left open, which is causing issues with script tags in particular. If I link an external script in the head element then due to the resulting non-closed script tag the rest of the document is considered part of the script and not displayed as HTML.
In order to resolve this I included a hash table of Void HTML tags and added a field self-closing-p to the element class that is loaded from this table. When an element is written the system checks if it's empty and not self-closing, if so an associated end tag is included.
I also fixed some typos and tried to smooth out the readme.