Skip to content

fix(AIP-203): disallow field_behavior in oneof #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
noahdietz wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(AIP-203): disallow field_behavior in oneof #1181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21b4a6e
fix(AIP-203): disallow field_behavior in oneof
noahdietz Jul 21, 2023
86355dd
Merge branch 'master' into disallow-oneof-fb
noahdietz Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aip/general/0203.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ RecognitionAudio audio = 2 [(google.api.field_behavior) = REQUIRED];
```

- APIs **must** apply the `google.api.field_behavior` annotation on every field
on a message or sub-message used in a request.
on a message or sub-message used in a request, except for fields in a `oneof`.
- Fields within a `oneof` **must not** use `google.api.field_behavior`.
- The annotation **must** include any [google.api.FieldBehavior][] values that
accurately describe the behavior of the field.
- `FIELD_BEHAVIOR_UNSPECIFIED` **must not** be used.
Expand Down