🔒 fix: log git_sha failures and fix linting/formatting#12
Conversation
- Narrowed exception scope and added logging in 'git_sha'. - Fixed unused import in 'aibom/bundle.py'. - Reformatted codebase with black to satisfy CI. Co-authored-by: akumar0205 <9454948+akumar0205@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Improved 'git_sha' robustness and visibility. - Fixed 'test_validation_fixtures_cover_valid_and_invalid_cases' by ensuring 'invalid_aibom_missing_field.json' actually misses the 'generated_at' field (previously it had a valid 'generated_at' inherited implicitly or was failing on 'artifact_sha256' first). - Fixed unused import in 'aibom/bundle.py'. - Applied black formatting. Co-authored-by: akumar0205 <9454948+akumar0205@users.noreply.github.com>
1 participant
This PR addresses the security vulnerability where 'git_sha' failed silently. It also fixes linting and formatting issues that were causing CI failures.
Changes:
PR created automatically by Jules for task 471702373912307449 started by @akumar0205