Refactor constants in balancer/core.py and cleanup#19
Conversation
- Moved CRITICAL_LOW_DAYS and BASE_OVERSTOCK_DAYS to module level - Updated calculate_dynamic_threshold to use BASE_OVERSTOCK_DAYS as default - Removed local constant definitions in detect_imbalances - Added .gitignore and removed tracked __pycache__ files Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Extracted CRITICAL_LOW_DAYS and BASE_OVERSTOCK_DAYS to module level in balancer/core.py to improve maintainability. Updated calculate_dynamic_threshold to use the module constant as a default argument. Also added a .gitignore file and removed accidentally tracked pycache files.
PR created automatically by Jules for task 14735259187251498578 started by @alfieprojectsdev