Refactor balancer constants to module level#20
Conversation
Moved CRITICAL_LOW_DAYS and BASE_OVERSTOCK_DAYS constants from detect_imbalances function to module level in balancer/core.py for better maintainability. Updated calculate_dynamic_threshold to use BASE_OVERSTOCK_DAYS as the default value. Refactored detect_imbalances to use these global constants. Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Extracted
CRITICAL_LOW_DAYS(15) andBASE_OVERSTOCK_DAYS(90) fromdetect_imbalancesto the top level ofbalancer/core.py.Updated
calculate_dynamic_thresholdto useBASE_OVERSTOCK_DAYSas the default value forbase_threshold_days.Refactored
detect_imbalancesto remove local constant definitions and redundant arguments.Verified with
pytest balancer/test_balancer.py.PR created automatically by Jules for task 5658023256262013778 started by @alfieprojectsdev