🧹 Extract magic number 30 in balancer/core.py#28
Conversation
Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
30used inneeded_qtycalculation to a module-level constantTARGET_STOCK_DAYS. Also movedCRITICAL_LOW_DAYSandBASE_OVERSTOCK_DAYSto the module level and updatedcalculate_dynamic_thresholdto useBASE_OVERSTOCK_DAYSas the default value. Added.gitignoreto prevent committing__pycache__files.30(target stock days) and centralizing configuration constants. Moving constants to the module level makes them easier to find and modify. Cleaning up__pycache__ensures a clean repository.pytest balancer/and all tests passed. Manually verified the changes inbalancer/core.py.PR created automatically by Jules for task 10200281598044358999 started by @alfieprojectsdev