Skip to content

🔒 Fix: Missing Input Validation for Transaction Quantity - #31

Open
alfieprojectsdev wants to merge 1 commit into
mainfrom
fix-transaction-form-validation-9937947492711592989
Open

🔒 Fix: Missing Input Validation for Transaction Quantity#31
alfieprojectsdev wants to merge 1 commit into
mainfrom
fix-transaction-form-validation-9937947492711592989

Conversation

@alfieprojectsdev

Copy link
Copy Markdown
Owner

This PR addresses a security vulnerability where the transaction form allowed invalid quantities (e.g., 0 or negative numbers for dispensing) to be submitted.

Changes:

  • Implemented strict validation checks in handleDispense, handleReceive, and handleAdjust.
  • Added an error message display in the UI.
  • Ensured ADJUST still supports negative numbers for stock corrections, while preventing 0.
  • Ensured DISPENSE and RECEIVE only accept positive quantities to avoid confusion and potential double-negative logic issues.

Verification:

  • Verified manually using a Playwright script that 0 and negative inputs are blocked for Dispense/Receive, but allowed for Adjust (negative).
  • Verified that valid inputs still work.
  • Ran linting and build checks.

PR created automatically by Jules for task 9937947492711592989 started by @alfieprojectsdev

…tity

- Added strict validation in `TransactionForm.tsx` handlers:
  - `DISPENSE` and `RECEIVE` now require `qty > 0`.
  - `ADJUST` now requires `qty != 0`.
  - Added an `error` state to display validation messages in the UI.
- Preserved negative quantity support for `ADJUST` to allow stock reduction.
- Extracted `handleReceive` and `handleAdjust` for cleaner code structure.

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant