Skip to content

🧹 Replace deprecated substr with substring in TranscriptViewer#18

Open
alfieprojectsdev wants to merge 1 commit into
mainfrom
fix/replace-deprecated-substr-4011063382388960841
Open

🧹 Replace deprecated substr with substring in TranscriptViewer#18
alfieprojectsdev wants to merge 1 commit into
mainfrom
fix/replace-deprecated-substr-4011063382388960841

Conversation

@alfieprojectsdev

Copy link
Copy Markdown
Owner

🎯 What: Replaced the deprecated String.prototype.substr(14, 5) with String.prototype.substring(14, 19) in field-logic/src/components/TranscriptViewer.tsx.
💡 Why: substr is deprecated and not recommended for use. substring (or slice) is the standard alternative. This change improves code health and future compatibility.
Verification:

  • Extracted the timestamp formatting logic into a helper function formatTimestamp.
  • Created a new unit test file field-logic/src/components/TranscriptViewer.test.ts to verify the logic.
  • Ran tests with npx vitest run and confirmed they pass.
  • Verified syntax with prettier.
    Result: The code is cleaner, follows modern standards, and is now testable.

PR created automatically by Jules for task 4011063382388960841 started by @alfieprojectsdev

- Replaced `substr(14, 5)` with `substring(14, 19)` for timestamp formatting.
- Extracted logic to `formatTimestamp` helper function.
- Added unit tests in `TranscriptViewer.test.ts`.

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant