🧹 Replace deprecated substr with substring in TranscriptViewer#18
🧹 Replace deprecated substr with substring in TranscriptViewer#18alfieprojectsdev wants to merge 1 commit into
Conversation
- Replaced `substr(14, 5)` with `substring(14, 19)` for timestamp formatting. - Extracted logic to `formatTimestamp` helper function. - Added unit tests in `TranscriptViewer.test.ts`. Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Replaced the deprecated
String.prototype.substr(14, 5)withString.prototype.substring(14, 19)infield-logic/src/components/TranscriptViewer.tsx.💡 Why:
substris deprecated and not recommended for use.substring(orslice) is the standard alternative. This change improves code health and future compatibility.✅ Verification:
formatTimestamp.field-logic/src/components/TranscriptViewer.test.tsto verify the logic.npx vitest runand confirmed they pass.prettier.✨ Result: The code is cleaner, follows modern standards, and is now testable.
PR created automatically by Jules for task 4011063382388960841 started by @alfieprojectsdev