Skip to content

🧪 Testing Improvement: Add edge case test for unknown routing operator#4

Open
alfieprojectsdev wants to merge 1 commit into
mainfrom
test-routing-operator-fallback-10311795524156386443
Open

🧪 Testing Improvement: Add edge case test for unknown routing operator#4
alfieprojectsdev wants to merge 1 commit into
mainfrom
test-routing-operator-fallback-10311795524156386443

Conversation

@alfieprojectsdev

Copy link
Copy Markdown
Owner

The SurveyEngine's routing logic in checkCondition defaults to false for unknown operators. While this behavior is intended, it was not explicitly tested. I have added a test case that:

  1. Defines a survey with a routing rule using an unknown operator (non_existent_op).
  2. Simulates an answer submission.
  3. Asserts that the engine ignores the invalid rule and follows the default route.

Due to network restrictions in the environment, npx vitest run was unavailable. I verified the logic manually using a Node script with --experimental-strip-types to ensure the SurveyEngine behaves as expected.


PR created automatically by Jules for task 10311795524156386443 started by @alfieprojectsdev

This commit adds a new test case to `field-logic/src/lib/engine.test.ts` to verify that the `SurveyEngine` correctly handles unknown routing operators by defaulting to `false` and falling back to the default route. This ensures the engine is resilient to typos or unsupported operators in survey definitions.

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant