🧪 Testing Improvement: Add edge case test for unknown routing operator#4
🧪 Testing Improvement: Add edge case test for unknown routing operator#4alfieprojectsdev wants to merge 1 commit into
Conversation
This commit adds a new test case to `field-logic/src/lib/engine.test.ts` to verify that the `SurveyEngine` correctly handles unknown routing operators by defaulting to `false` and falling back to the default route. This ensures the engine is resilient to typos or unsupported operators in survey definitions. Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The
SurveyEngine's routing logic incheckConditiondefaults tofalsefor unknown operators. While this behavior is intended, it was not explicitly tested. I have added a test case that:non_existent_op).defaultroute.Due to network restrictions in the environment,
npx vitest runwas unavailable. I verified the logic manually using a Node script with--experimental-strip-typesto ensure theSurveyEnginebehaves as expected.PR created automatically by Jules for task 10311795524156386443 started by @alfieprojectsdev