chore(deps-dev): bump @types/node from 18.19.130 to 26.1.2 in /extensions/vscode - #595
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.19.130 to 26.1.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.1.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
AlvaroBalbin
left a comment
AlvaroBalbin
left a comment
There was a problem hiding this comment.
The thing I'd want a maintainer to actually decide here is whether typing this extension against Node 26 is correct. extensions/vscode/package.json:95 jumps the dev types eight majors, but engines.vscode two lines further up is still ^1.74.0, and VS Code 1.74 runs extensions on a Node 16 host, while .github/workflows/vscode-ext.yml builds and tests in a node:24.4.1 container. Since tsconfig.json has "types": ["node", ...] and code such as src/extension/services/shellEnv.ts and GitService.ts touches process and child_process directly, tsc will now accept APIs that exist on neither the oldest supported host nor CI, and yarn compile won't flag it. The usual convention for VS Code extensions is to keep @types/node on the major matching the Node that ships with the minimum supported VS Code, so if you take this bump I'd expect engines.vscode to move with it. Worth noting plugins/open-code-review/opencode/package.json is still on ^24.0.0, so it seems better to pick a target deliberately than to let the two drift apart via separate Dependabot PRs.
1 participant
Bumps @types/node from 18.19.130 to 26.1.2.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)