feat(allowlist): add Nix support - #615
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
lizhengfeng101
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding Nix support — the rule doc is thorough and well-structured!
One thing missing: whenever system_rules.json is updated, the documentation table in the review-rules pages needs to stay in sync (see PR #612 for the pattern). Please rebase onto the latest main and add a **/*.nix → nix.md row to each locale's table:
pages/src/content/docs/en/review-rules.mdpages/src/content/docs/zh-cn/review-rules.mdpages/src/content/docs/ja/review-rules.mdpages/src/content/docs/ko/review-rules.mdpages/src/content/docs/ru/review-rules.md
The new row should go after the **/*.bicep entry and before the *(fallback) line, matching the declaration order in system_rules.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Nix allowlist support by recognizing
.nixfiles, registering a Nix-specific review rule, and covering case-insensitive extension matching in the allowlist test.Type of Change
How Has This Been Tested?
make testpasses locallyManual testing:
Checklist
go fmt,go vet)Related Issues
Fixes #614
Refs #470