refactor(test): unify config compat helpers to use cobra subcommand tree - #656
Merged
lizhengfeng101 merged 1 commit intoAug 1, 2026
Merged
Conversation
runConfig manually dispatched config subcommands and parseConfigArgs did manual arg slicing, duplicating the routing the production config command already defines with cobra. Rebuild runConfig as a fresh cobra tree mirroring production (matching the runSession pattern), and drop parseConfigArgs, configAction, and configParseError, which are no longer used. Dispatch behavior is unchanged and stays covered by the existing runConfig/config_dispatch tests. Closes alibaba#638
|
|
Contributor
|
✅ OpenCodeReview: No supported files changed. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runConfigandparseConfigArgsincompat_test.gostill did manual arg slicing and hand-written subcommand dispatch, while the other compat helpers (runSession,parseReviewFlags,parseScanFlags) were already migrated to cobra in #625. That duplicated the routing the productionconfigcommand defines with cobra, so the two could drift.This rebuilds
runConfigas a fresh cobra tree that mirrors the production command (set= ExactArgs(2),unset= ExactArgs(1),provider/model= NoArgs), matching therunSessionpattern, and dropsparseConfigArgs,configAction, andconfigParseError, which are then unused.The
parseConfigArgsunit tests are removed along with the helper; the same dispatch behavior (unknown subcommand, missing args, provider/model with args, empty args) is already covered by therunConfigtests inconfig_dispatch_test.goandconfig_cmd_test.go. Behavior is unchanged and the full suite passes.go test ./...andmake checkpass.Closes #638
Disclosure: prepared with AI assistance.