Make clipboard paste the default by grohith327 · Pull Request #811 · altic-dev/FluidVoice

grohith327 · 2026-08-08T04:44:30Z

Description

Override the default to "Clipboard paste" as the recommended option
Simulate Cmd+v in order to insert the text reliably into the app

Type of Change

Related Issue or Discussion

#802

Testing

Tested on Apple Silicon Mac
Tested on macOS version:
Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources
Ran tests locally: insertion across different apps and varying lenghts

Screenshots / Video

Attach screenshots or a video for UI, UX, settings, onboarding, overlay, menu bar, or visual behavior changes.

No UI/visual changes; screenshots/video are not applicable.

Notes

Add reviewer context, rollout notes, or known tradeoffs here.

greptile-apps · 2026-08-08T04:47:23Z

Greptile Summary

This PR makes clipboard paste the recommended default and introduces coordinated Cmd+V delivery with focus recovery, clipboard snapshot/restore handling, recoverable failure UI, and expanded integration coverage.

Routes dictation and rewrite output through the new paste-delivery coordinator.
Preserves or intentionally retains transcript clipboard content according to user settings.
Adds migration and tests for the new default insertion mode.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

_{Reviews (6): Last reviewed commit: "remove benchmark tests" | Re-trigger Greptile}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 719f3de47b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

grohith327 · 2026-08-08T04:49:35Z

@greptileai review again based on my replies

github-actions · 2026-08-08T04:53:55Z

FluidVoice PR build ready

Download FluidVoice-PR-811-5dd3ea1ff0dd

The artifact contains the ad-hoc-signed app ZIP, Xcode archive, build manifest, and installation instructions. It expires 5 days after the build.

Install the app

Extract the downloaded artifact, then extract FluidVoice-PR-811.app.zip.
Move FluidVoice Make clipboard paste the default #811.app into the /Applications folder.

Open Terminal and remove the download quarantine marker:

xattr -dr com.apple.quarantine "/Applications/FluidVoice #811.app"

In Applications, Control-click FluidVoice Make clipboard paste the default #811.app and choose Open.
If macOS still blocks it, open System Settings → Privacy & Security, click Open Anyway, and confirm.

This build has its own app identity, so its permissions are separate from the release version of FluidVoice.

View workflow run

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6542d82fc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-11T04:28:07Z

+
+@MainActor
+final class SystemPasteCommandPoster: PasteCommandPosting {
+    private static let vKeyCode: CGKeyCode = 0x09


Resolve the paste key using the active keyboard layout

On keyboard layouts where virtual key code 0x09 does not produce “v”, this posts Command plus a different character instead of Command+V. The previous implementation resolved the key code through the current TIS layout, but this hard-coded replacement still returns success after posting, so the coordinator reports the transcript as delivered even though no paste occurred. Restore layout-aware lookup, including reevaluation after runtime layout switches.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-11T04:28:08Z

+@MainActor
+final class PasteDeliveryCoordinator {
+    static let shared = PasteDeliveryCoordinator()
+    nonisolated static let defaultSettlementDelayNanoseconds: UInt64 = 500_000_000


Keep the temporary clipboard available for slow paste targets

When a busy or asynchronous target handles the posted Command+V more than 500 ms later, settlement has already restored the original clipboard, so the target pastes the old contents instead of the transcript while delivery was reported successful. The newly added testDefaultSettlementDelayIsLongEnoughForSlowPasteTargets at Tests/FluidDictationIntegrationTests/PasteDeliveryCoordinatorTests.swift:228-230 explicitly requires 1.5 seconds, so the current constant also makes that test fail.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6169400fd6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad2a01b3a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5dd3ea1ff0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-11T04:58:18Z

+        let isStillFocused = context.pid == TypingService.currentFocusedPID() &&
+            (context.element == nil || TypingService.isCapturedFocusStillActive(context))
+        return (context.pid, !isStillFocused)


Restore the exact captured field before delivery

When focus moves to another editable element in the same application during recording, this can incorrectly decide that the original field is still focused: isCapturedFocusStillActive ultimately accepts any text-like AX element owned by the same PID, even when it is not CFEqual to the captured element. The restore is then skipped and the global Cmd+V lands in the newly focused field rather than the recorded destination; require exact element identity here or always prepare the captured target when the focused element changed.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-11T04:58:18Z

+    private static func restoreExactTarget(_ context: RecordingTargetContext) async -> Bool {
+        guard AXIsProcessTrusted(), context.window != nil, context.element != nil else { return false }


Allow focus restoration without captured window metadata

For applications that expose the focused AX element but not kAXFocusedWindowAttribute or kAXMainWindowAttribute, the captured context legitimately has window == nil; this guard rejects it before attempting to set kAXFocusedAttribute on the usable element, and the recovery guard rejects it again. After any focus displacement, delivery therefore reports targetRestoreFailed even though the exact field could still be restored; require the element and treat the window raise as optional, as the previous restoration path did.

Useful? React with 👍 / 👎.

greptile-apps Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread Sources/Fluid/Services/PasteDeliveryCoordinator.swift Outdated

Comment thread Sources/Fluid/Persistence/SettingsStore.swift

chatgpt-codex-connector Bot reviewed Aug 8, 2026

View reviewed changes

Comment thread Sources/Fluid/Services/RewriteModeService.swift

Comment thread Sources/Fluid/Views/RewriteModeView.swift

greptile-apps Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread Sources/Fluid/Services/PasteDeliveryCoordinator.swift

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

grohith327 added 6 commits August 10, 2026 21:28

Migrate to clipboard paste

f278f76

increase limits for snapshot backup

49ab5f4

restore image clipboard

f0d1664

Fix restoring image snapshot

0ce5c80

reduce snapshot restore time

5f51fd4

fix rebase

6169400

grohith327 force-pushed the rohith/reliable-paste branch from c6542d8 to 6169400 Compare August 11, 2026 04:32

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread Sources/Fluid/Services/PasteDeliveryCoordinator.swift

Comment thread Sources/Fluid/Services/PasteDeliveryCoordinator.swift

Comment thread Sources/Fluid/Services/PasteDeliveryCoordinator.swift

grohith327 added 2 commits August 10, 2026 21:39

support different keyboard layouts

12d0bfb

fix lint errors

ad2a01b

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread Sources/Fluid/ContentView.swift

Comment thread Sources/Fluid/Services/PasteDeliveryCoordinator.swift

Comment thread Sources/Fluid/Services/PasteDeliveryCoordinator.swift

remove benchmark tests

5dd3ea1

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

		private static func restoreExactTarget(_ context: RecordingTargetContext) async -> Bool {
		guard AXIsProcessTrusted(), context.window != nil, context.element != nil else { return false }

Uh oh!

Conversation

grohith327 commented Aug 8, 2026

Description

Type of Change

Related Issue or Discussion

Testing

Screenshots / Video

Notes

Uh oh!

greptile-apps Bot commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

grohith327 commented Aug 8, 2026

Uh oh!

github-actions Bot commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

FluidVoice PR build ready

Install the app

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

greptile-apps Bot commented Aug 8, 2026 •

edited

Loading

github-actions Bot commented Aug 8, 2026 •

edited

Loading