Open
Conversation
ghost
suggested changes
Aug 4, 2021
| dc.vm.network "private_network", ip: "10.64.6.%s" % [10+n], netmask: 24, virtualbox__intnet: "intnet" | ||
| dc.vm.box = "BaseALT/alt-server-8.2-x86_64" | ||
| dc.vm.box_version = "1.0.0" | ||
| dc.vm.box_download_checksum = "db0d0f26575bafd0bb4989dc00d85539e0fd9272c943b373ebbb6d978a3c15ee" |
There was a problem hiding this comment.
Why are you deleting lines with checksum?
| shell: grep -q 'bind-dns' /etc/bind/named.conf || echo 'include "/var/lib/samba/bind-dns/named.conf";' >> /etc/bind/named.conf | ||
|
|
||
| - name: generate options.conf for bind | ||
| template: |
There was a problem hiding this comment.
Please specify file permissions while deploying file.
| shell: grep -q KRB5RCACHETYPE /etc/sysconfig/bind || echo 'KRB5RCACHETYPE="none"' >> /etc/sysconfig/bind | ||
|
|
||
| - name: Add BIND9_DLZ plugin for bind | ||
| shell: grep -q 'bind-dns' /etc/bind/named.conf || echo 'include "/var/lib/samba/bind-dns/named.conf";' >> /etc/bind/named.conf |
There was a problem hiding this comment.
I suggest looking at lineinfile Ansible module for this kind of tasks.
| //listen-on { localnets; {{ samba_network }}; }; | ||
| forwarders { {{ samba_dns_forward }}; }; | ||
| allow-query { localnets; {{ samba_network }}; }; | ||
| //allow-query-cache { localnets; {{ samba_network }}; }; |
ghost
added
the
AntProBasealt
force-pushed
the
dns_backend
branch
from
5670386 to
be74de7
Compare
AntProBasealt
force-pushed
the
dns_backend
branch
2 times, most recently
from
8d58404 to
1dea607
Compare
AntProBasealt
force-pushed
the
dns_backend
branch
from
1dea607 to
2931640
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rights for bind-dns.