fix: reset prompt guards on abort to prevent soft-lock window - #10
Open
robbe1912 wants to merge 1 commit into
Open
fix: reset prompt guards on abort to prevent soft-lock window#10robbe1912 wants to merge 1 commit into
robbe1912 wants to merge 1 commit into
Conversation
abortSession did not reset promptSubmissionRef or sendingState. The in-flight promptAsync could take seconds to settle after server abort, during which the Send button stayed disabled and any new send was rejected by the active-guard in sendPrompt. Reset both immediately after client.session.abort resolves. sendPrompt's own finally block sets the same values when it eventually runs, so the two writes compose to the same end state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
\�bortSession\ resets the running session on the server but does not clear the client-side guards (\promptSubmissionRef\ + \sendingState.active). Until the in-flight \promptAsync\ promise settles, those guards stay active, blocking new prompt submission and leaving the conversation-mode state machine in a half-running state.
Fix
Clear \promptSubmissionRef.current = false\ and \setSendingState({ active: false })\ inside \�bortSession\ so the client immediately returns to an idle, submittable state. Server abort and client guards are now decoupled — either settling first no longer blocks the UI.
Files changed
Validation
pm run typecheck\ ✓
pm run lint\ ✓
pm run test:fake-server:self\ ✓
Notes
Optional follow-up hardening: scope the reset to the aborting \sessionId\ so aborting session A does not clear session B's lock (rare in practice — single active send at a time). 1-line change.