feat(reconciliation): support held transactions and invoice requests - #428
Draft
PatrickDEissler with Copilot wants to merge 2 commits into
Draft
feat(reconciliation): support held transactions and invoice requests#428PatrickDEissler with Copilot wants to merge 2 commits into
PatrickDEissler with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: PatrickDEissler <77415730+PatrickDEissler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add functionality to set bank transactions on hold
feat(reconciliation): support held transactions and invoice requests
Aug 31, 2026
Collaborator
Todo
NOTE: All feedback is in respect to "Request Invoice". The basic "On Hold" feature is fine. |
PatrickDEissler
requested changes
Sep 4, 2026
PatrickDEissler
left a comment
Collaborator
There was a problem hiding this comment.
Todo
- Make Recipient Type a link field and Recipient a dynamic link
- Add a JS and new fields, that fetches the email address from the respective dynamic link -> And show the field (also let it be editable) -> how to fetch email: User =
email, Employee =user_id, Contact =email_id - Make the doctype and dynamic link field not mandatory, only use them as a help to fetch email addresses. Only the resulting email address for sending requests shall be mandatory
- Also add a date field (that is pre-calculated based on the On Hold Threshold (from Banking Settings), till when the transaction will be on hold -> This calculated default can be changed/deleted.
NOTE: All feedback is in respect to "Request Invoice". The basic "On Hold" feature is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unreconciled transactions awaiting invoices repeatedly appear in Bank Reconciliation Beta. This adds a temporary hold workflow and a direct invoice-request action.
On-hold workflow
On Hold Untilto Bank Transactions.Invoice requests
Configuration