fix: correct API server deployment manifests for gRPC, health checks, and auth mock#787
Open
markturansky wants to merge 2 commits intoambient-code:mainfrom
Open
fix: correct API server deployment manifests for gRPC, health checks, and auth mock#787markturansky wants to merge 2 commits intoambient-code:mainfrom
markturansky wants to merge 2 commits intoambient-code:mainfrom
Conversation
… and auth mock - Remove unsupported --enable-sentry flag from deployment manifest - Add gRPC server flags (--enable-grpc=true, --grpc-server-bindaddress=:9000) - Add gRPC service port and route definitions across base and overlays - Fix liveness probe path from /api/ambient-api-server to /api/ambient - Fix environment variable from OCM_ENV to AMBIENT_ENV - Set enable-mock=true in production environment to skip missing API client secrets - Update ENABLE_AUTHZ_MOCK default to true in service template 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
markturansky
commented
Mar 3, 2026
| "v": "1", | ||
| "debug": "false", | ||
| "enable-mock": "false", | ||
| "enable-mock": "true", |
Contributor
Author
There was a problem hiding this comment.
this enable-mock is poorly named (mock for what?), but it's for the authz stub in the stack.
Project.ID now equals Project.Name (the Kubernetes namespace), making project_id a human-readable namespace reference throughout sessions and project_settings instead of an opaque KSUID. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--enable-sentryflag that was causing pod crash loops (unknown flag in rh-trex-ai v0.0.14)--enable-grpc=true,--grpc-server-bindaddress=:9000, service port 9000, and gRPC routes across base and overlay manifests/api/ambient-api-serverto/api/ambientOCM_ENVtoAMBIENT_ENVenable-mock=truein production environment and service template to avoid crash when API client secret files are absentFiles Changed
components/ambient-api-server/cmd/ambient-api-server/environments/e_production.go— enable-mock default to truecomponents/ambient-api-server/templates/service-template.yml— ENABLE_AUTHZ_MOCK default to truecomponents/ambient-api-server/templates/route-template.yml— added gRPC routecomponents/manifests/base/ambient-api-server-service.yml— removed sentry, added gRPC, fixed probe & env varcomponents/manifests/base/ambient-api-server-route.yml— added gRPC routecomponents/manifests/overlays/local-dev/ambient-api-server-route.yaml— added gRPC routecomponents/manifests/overlays/production/ambient-api-server-route.yaml— added gRPC routeTest plan
🤖 Generated with Claude Code