AmdSmiPlugin update: cper AFID val#122
Open
alexandraBara wants to merge 2 commits intodevelopmentfrom
Open
Conversation
graepaul
reviewed
Feb 4, 2026
Collaborator
graepaul
left a comment
There was a problem hiding this comment.
Added some comments.
I think there would be benefit to have AFID be automatically generated on collected CPERs
| xgmi_metric: Optional[list[XgmiMetrics]] = Field(default_factory=list) | ||
| xgmi_link: Optional[list[XgmiLinks]] = Field(default_factory=list) | ||
| cper_data: Optional[list[FileModel]] = Field(default_factory=list) | ||
| cper_afid: Optional[int] = None |
Collaborator
There was a problem hiding this comment.
Should this be a list like cper_data
|
|
||
| # If cper_file_path is provided, get AFID from the CPER file | ||
| if args and args.cper_file_path: | ||
| afid = self._get_cper_afid(args.cper_file_path) |
Collaborator
There was a problem hiding this comment.
I think we should have this also be performed on recently collected cpers automatically, in addition to having this option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test:
or
where plugin_config.json: