Skip to content

docs: add architecture guide, developer guide, and roadmap - #13

Open
wilsonhj wants to merge 1 commit into
americanexpress:mainfrom
wilsonhj:upstream/docs-guides
Open

docs: add architecture guide, developer guide, and roadmap#13
wilsonhj wants to merge 1 commit into
americanexpress:mainfrom
wilsonhj:upstream/docs-guides

Conversation

@wilsonhj

@wilsonhj wilsonhj commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What this adds

Three contributor-facing guides, absent today:

  • docs/ARCHITECTURE.md — module map, EAS auth flow, LCEL integration, MCP design, upstream-dependency risk table, and a "bug history" appendix explaining why several modules look the way they do.
  • docs/DEVELOPER_GUIDE.md — setup (CONFIG_PATH, example.env, config.yml schema), test/lint/type tooling (uv, make targets), debugging tips, contribution conventions.
  • docs/ROADMAP.md — proposed feature direction, explicitly separated from bug tracking.

All technical claims were fact-checked against the source (module/class names, env vars, config schema, deprecation timelines, lint limits). One correction made relative to earlier drafts: the env-var table no longer lists HTTPS_PROXY (nothing in the codebase reads it — outbound proxying is configured via config.yml's proxy: {host, port} block).

⚠️ Sequencing — merge LAST in the series

These guides document the codebase after the accompanying fix PRs (deps pin, sanitizer/orchestrator, model/session/config, MCP). ~16 statements reference post-fix state — e.g. SessionMap.get_valid_llm(), the double-checked-locking singleton, the orchestrator's .invoke()/.ainvoke() migration, and the langchain<0.4.0 pins. Merging this PR before those would make the docs describe code that isn't on main yet. Happy to hold/rebase this until the rest of the series lands.

Co-authored-by: Claude noreply@anthropic.com

Adds three contributor-facing guides under docs/:
- ARCHITECTURE.md: layered architecture, session/model flow, upstream
  risk surface, and a bug-history appendix.
- DEVELOPER_GUIDE.md: setup, configuration schema, and debugging tips.
- ROADMAP.md: non-committal backlog of potential improvements.

These guides document the post-fix state of the codebase. They reference
modules, symbols, and behavior (e.g. get_valid_llm, thread-safe SessionMap
singleton, LCEL error re-raising, and the langchain<0.4.0 / mcp-adapters
<0.2.0 dependency pins) that only exist after the bug-fix and dependency-pin
PRs. This PR should therefore be merged AFTER those fix PRs, at which point
the forward references become accurate.

Includes one correction to the environment-variable table: HTTPS_PROXY is
not read anywhere in the codebase (example.env defines REQUESTS_CA_BUNDLE
only, and outbound proxying is configured via the config.yml proxy {host,
port} block). The row now lists REQUESTS_CA_BUNDLE alone and points to the
config.yml proxy block for proxying.

Co-authored-by: Claude <noreply@anthropic.com>
@wilsonhj

wilsonhj commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Verification note — SKIP (no runtime surface)

Docs-only change, so there's nothing to execute. In lieu of runtime verification: all technical claims in the three guides were fact-checked against the source at this branch (module/class names, env vars incl. the CONFIG_PATH requirement, config schema, LangChain deprecation timelines, lint limits), and the one inaccuracy found in earlier drafts (HTTPS_PROXY as an env var — nothing in the codebase reads it) is corrected in this PR. Sequencing note in the PR body stands: merge after #10/#7/#11/#12, since ~16 statements document post-fix behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant