fix(wallpapers): resolve invisible transition animations#920
Merged
Conversation
…nager - Move engine enable/disable logic from WallpaperEngine into WallpaperManager.set_wallpaper() - Add finished signal to WallpaperEngine instead of calling WallpaperManager directly - Remove engine param from ImageGallery, callers now use unified manager API - Consolidate set_wallpaper and _commit_wallpaper into single function - Fix duplicate _run_after_thread call in change_background
…scaling - Divide WorkerW and monitor rects by devicePixelRatio so wallpapers render at the right position and size when Windows scaling is > 100% - Use SmoothTransformation in all per-monitor scaling helpers for better visual quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #917
Resolves an issue where dynamic wallpaper animations would fail to display (become invisible) on specific Windows versions.
DWM refuses to composite a child window inside the desktop WorkerW layer if the window has the
WS_EX_LAYEREDflag active at the exact momentSetParentis called. This PR temporarily strips theWS_EX_LAYEREDflag during the SetParent transition and immediately restores it. This safely bypasses the DWM bug while keeping Qt's opacity fade-in functionality working perfectly without any black flashes or blinks.Also I have enabled Windows 10 support to test