Skip to content

fix: make Show Simulation Box checkbox toggleable (fixes #308) #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andeplane merged 3 commits into from
Feb 26, 2026
Merged

fix: make Show Simulation Box checkbox toggleable (fixes #308) #309

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a415ce
fix: make Show Simulation Box checkbox toggleable (fixes #308)
Feb 26, 2026
357946e
refactor: tighten useEffect dependency array for showSimulationBox sync
Feb 26, 2026
a8f3259
fix: use direct value for setRenderSettings (fixes typecheck)
Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/containers/View.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,15 +403,18 @@ const View = ({ visible, isEmbeddedMode = false }: ViewProps) => {
embedConfig.enableParticlePicking,
]);

// Apply showSimulationBox setting from embed config
// Apply showSimulationBox setting from embed config (only in embedded mode)
useEffect(() => {
if (renderSettings.showSimulationBox !== embedConfig.showSimulationBox) {
if (
isEmbeddedMode &&
renderSettings.showSimulationBox !== embedConfig.showSimulationBox
) {
setRenderSettings({
...renderSettings,
showSimulationBox: embedConfig.showSimulationBox,
});
}
}, [embedConfig.showSimulationBox, renderSettings, setRenderSettings]);
}, [isEmbeddedMode, embedConfig.showSimulationBox, renderSettings, setRenderSettings]);

// Update camera planes based on simulation box bounds
useEffect(() => {
Expand Down