Conversation
Schlevidon
requested changes
Feb 26, 2026
Collaborator
Schlevidon
left a comment
Schlevidon
left a comment
There was a problem hiding this comment.
Looks good! There are a few things that could be improved.
added 6 commits
March 3, 2026 12:05
new file: toolbox/examples/friction_model/friction_model_RHS.m new file: toolbox/examples/friction_model/friction_model_test.m modified: toolbox/examples/liveExamples/canonicalExRHS_test_live.mlx
new file: toolbox/examples/friction_model/F_fric_mod.m new file: toolbox/examples/friction_model/F_fric_mod2.m new file: toolbox/examples/friction_model/friction_model_RHSmod.m new file: toolbox/examples/friction_model/friction_model_RHSmod2.m new file: toolbox/examples/friction_model/friction_model_mod_test.m modified: toolbox/examples/liveExamples/CanonicalSensitivities.mlx
deleted: toolbox/examples/friction_model/F_fric.m renamed: toolbox/examples/friction_model/friction_model_RHSmod.m -> toolbox/examples/friction_model/friction_RHS_filippov.m renamed: toolbox/examples/friction_model/friction_model_RHSmod2.m -> toolbox/examples/friction_model/friction_RHS_no_filippov.m deleted: toolbox/examples/friction_model/friction_model_RHS.m renamed: toolbox/examples/friction_model/friction_model_mod_test.m -> toolbox/examples/friction_model/friction_model_comparison.m deleted: toolbox/examples/friction_model/friction_model_test.m renamed: toolbox/examples/friction_model/F_fric_mod2.m -> toolbox/examples/friction_model/helpers/F_fric_fil.m renamed: toolbox/examples/friction_model/F_fric_mod.m -> toolbox/examples/friction_model/helpers/F_fric_no_fil.m
modified: toolbox/examples/friction_model/friction_model_comparison.m modified: toolbox/examples/friction_model/helpers/F_fric_no_fil.m
… well as first ever sensitivity comparison/check for filippov sensitivities feature modified: toolbox/examples/friction_model/friction_model_comparison.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a frction model example to the examples library with two different formulations (filippov and non-filippov). Compares both versions in accuracy and is suited for comparison of sensitivities (needs to be implemented)