Make ConstraintConfig more generic by parameterizing the constrained attribute#71
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Make ConstraintConfig more generic by parameterizing the constrained attribute#71copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_888423834
branch
4 times, most recently
from
dee7ef8 to
390bbfd
Compare
…attribute This is the first step toward making the constraints truly generic. Instead of making each constraint take a specific attribute, make all the constraints accept common types. The contraints are them customize to extract the constrained attributes using mapping functions. PiperOrigin-RevId: 888423834
copybara-service
bot
force-pushed
the
test_888423834
branch
from
390bbfd to
0751afe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ConstraintConfig more generic by parameterizing the constrained attribute
This is the first step toward making the constraints truly generic. Instead of
making each constraint take a specific attribute, make all the constraints
accept common types. The contraints are them customize to extract the constrained
attributes using mapping functions.